feat: add docs source config and runtime env linkage#12182
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wanghe-fit2cloud The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6696e9e6d4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if !useIntlDocs && lang != "zh" { | ||
| useIntlDocs = true |
There was a problem hiding this comment.
In LoadRelease, the withByRegion branch still forces international docs when Language != zh, so a CN runtime configured as “Follow region” will fetch release notes from docs.1panel.pro for English UI users. This contradicts the new region-based mode and diverges from the frontend docsUrl getter (which uses region-only when docWithRegion is true), causing inconsistent doc/release-note links for the same runtime setting.
Useful? React with 👍 / 👎.
| } | ||
| if (docSourceChanged) { | ||
| await updateSetting({ key: 'DocSource', value: form.docSource }); | ||
| globalStore.docWithRegion = form.docSource === 'withByRegion'; |
There was a problem hiding this comment.
docWithRegion is only updated when the runtime-env drawer is saved, so fresh browsers/sessions start from the default store value instead of the persisted backend DocSource setting. If the server is already configured to withByLang, docs links remain region-based until a user re-saves this panel, producing incorrect links across clients.
Useful? React with 👍 / 👎.
3 participants
No description provided.